Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check before the getSvgPath to avoid clipping the entire element #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rafaelrcamargo
Copy link

This PR introduces a pre-check before the getSvgPath call. This means we'll show the "non-squircle" element until we get the actual element size. This won't influence components with width/height or defaultWidth/defaultHeight.

Before:

CleanShot.2024-09-29.at.23.32.45.mp4

After:

CleanShot.2024-09-29.at.23.33.35.mp4

Copy link

codesandbox bot commented Sep 30, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 0b7ed93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
squircle.js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 2:44am

@rafaelrcamargo
Copy link
Author

Hey @bring-shrubbery should I worry about the Changeset warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant