Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to support Laravel 10.x and 11.x versions. #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DmitrySidorenkoShim
Copy link
Contributor

hi @spekulatius

two years past and I need this package again for one project upgrade
this time I need it with Laravel 11.x and PHP 8.2
but I think requiring PHP 8.1 or greater is completely enough

it would be great if you could find some time to take a look at changes

most of the changes are for composer.json
I also added types and return declarations in classes

as about src/Commands/SitemapCommand.php crawlWebsite() change on :75 string
I had this error for XPathExpressionDiscoverer before:

Please end your selector with '/a': selectors should look for a elements so that the Discoverer can extract their href attribute for further crawling.

and the change fixed it

it looks like there is a conflict between my fork and your origin package
I will check it out later

hope to hear from u soon 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant