Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes, cleanups, and tweaks #1

Merged
merged 11 commits into from
Nov 3, 2024
Merged

Minor fixes, cleanups, and tweaks #1

merged 11 commits into from
Nov 3, 2024

Conversation

kylewlacy
Copy link
Member

This PR makes a few tweaks to the action:

  • Improve install-brioche.sh
    • Fix issue where using $HOME would error out before checks around $HOME (due to set -u shell option)
    • Take inputs via env vars to prevent potential shell escaping issues
    • Manually validate and expand env vars in install-dir using envsubst (this is only done if install-dir looks like it could contain an env var)
    • Add install-dir to $GITHUB_PATH directly in the shell script, instead of in a separate action step
    • Add the Brioche package installation path to $GITHUB_PATH as well, so installed packages are available
  • Update test workflow to install and use the hello_world package. This validates that installed packages are available after running the action
  • Update README
    • Various minor rewordings
    • Improve example workflow (fix brioche usage, switch to actions/checkout@v4)

@kylewlacy kylewlacy requested a review from asheliahut November 2, 2024 05:45
@kylewlacy kylewlacy merged commit 8d01e66 into main Nov 3, 2024
1 check passed
@kylewlacy kylewlacy deleted the installation-tweaks branch November 3, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants