[DCJ-31] Remove Slack notifications from PR lint action

[okotsopoulos]

https://broadworkbench.atlassian.net/browse/DCJ-31

The Helm Chart Linter runs only on commits to PRs. Slack notifications on the outcome are unnecessary and noisy. If the action fails, the PR cannot be merged.

Current state of #jade-spam (which Data Custodian Journeys team is in the process of auditing and consolidating):

Confirming that when this PR's lint run ran and succeeded, no notification was emitted to #jade-spam.

[rushtong]

👍🏽 We need to do this in our consent repos as well now that we have beehive slack integration

[fboulnois]

Looks good, I think in the future we should always tie tickets to PRs for compliance reasons (an auditor should should always be able to start with any ticket and/or PR to identify the work history / lineage).

[okotsopoulos]

Looks good, I think in the future we should always tie tickets to PRs for compliance reasons (an auditor should should always be able to start with any ticket and/or PR to identify the work history / lineage).

@fboulnois My understanding was that the compliance requirement applied to code which would ultimately make it into production, and removing this Slack notification on commits to PRs didn't fall into that camp. I'll look more closely at this to make sure I understand the requirement.

Either way, I can see the value to always putting a ticket and can add one (but our DCJ project currently is missing all of the elements required by compliance, Bill is working on it).

[okotsopoulos]

👍🏽 We need to do this in our consent repos as well now that we have beehive slack integration

@rushtong oh yes, this is only the tip of the iceberg for TDR's notifications! It felt like low-hanging fruit to remove given that it was running errantly on commits to PRs. We have emitted many positive signal notifications in the past that I look forward to trimming.