Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-28] Slack DCJ team on release failures, retries #268

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

okotsopoulos
Copy link
Contributor

@okotsopoulos okotsopoulos commented Apr 18, 2024

https://broadworkbench.atlassian.net/browse/DCJ-28

More thorough background: DataBiosphere/jade-data-repo#1654

I set up a new Github repository variable SLACK_NOTIFICATION_CHANNELS:

Screenshot 2024-04-19 at 10 20 14 AM

And made the following changes to existing Slack notifications:

  • chart-releaser, integrationChartBump: removed Slack notifications as these are called within releasedrumbrella.
  • releasedr, releasedrumbrella: reworked Slack notifications to be emitted by Sherlock on failures or retries to our variable-driven channel list.
    • I think we should have the insight we need into deployments from Beehive's Slack deploy hooks, but I am not confident enough to fully remove them. If / when these fail, we can take a closer look at the full suite of notifications that go out and pare down as needed.

I set up new Github repository variable SLACK_NOTIFICATION_CHANNELS = #dsp-data-custodian-journeys

chart-releaser and integrationChartBump are called within releasedrumbrella: I removed their existing Slack notifications.

I reworked releasedr and releasedrumbrella's Slack notifications to be emitted by Sherlock on failures or retries to our variable-driven channel list.  (I think we should have the insight we need into deployments from Beehive's Slack deploy hooks, but I am not confident enough to fully remove them.  If / when these fail, we can take a closer look at the full suite of notifications that go out and pare down as needed.)
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@okotsopoulos okotsopoulos merged commit 318d8f7 into master Apr 19, 2024
1 check passed
@okotsopoulos okotsopoulos deleted the okotsopo-DCJ-28-slack-audit branch April 19, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants