Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DT-1122] Apply zizmor suggestions #284

Merged
merged 3 commits into from
Jan 13, 2025
Merged

[DT-1122] Apply zizmor suggestions #284

merged 3 commits into from
Jan 13, 2025

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-1122

Summary

  • Do not persist credentials if not needed

@fboulnois fboulnois changed the title [DT-1122] Apply zizmor suggestions [DT-1122] Apply zizmor suggestions Jan 10, 2025
rushtong
rushtong approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois merged commit 986374a into master Jan 13, 2025
1 check passed
@fboulnois fboulnois deleted the fb-dt-1122-apply-zizmor-fixes branch January 13, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snf2ye snf2ye snf2ye approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboulnois @rushtong @snf2ye