VS-1246 Add more disk and add memory retry handling on SelectVariants task #9096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egy to handle retry with more memory.
mcovarr
reviewed
Feb 13, 2025
mcovarr
approved these changes
Feb 13, 2025
| @@ -1154,10 +1167,11 @@ task SelectVariants { | |||
| runtime { | |||
| docker: gatk_docker | |||
| cpu: 1 | |||
| memory: "${memory_mb} MiB" | |||
| memory: memory_gib + " GB" | |||
There was a problem hiding this comment.
this may be silly, but I don't know why you are changing how we're doing the string interpolation and setting the memory field here. Was the old way broken? Or is this just to bring it in line with how we do things elsewhere?
There was a problem hiding this comment.
I actually just lifted this from the other example of retry with more memory (in Extract) - really didn't think much of the change - but agree that we should stick with how we do things.
There was a problem hiding this comment.
I have updated this and retested with the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task SelectVariants failed several times in Echo filter set creation for what appeared to be memory (and maybe disk) space issues. This PR increases memory (more to system) and disk and lets the task handle Terra's retry with more memory strategy.
Passing integration test here