-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE-109 migrate to Dagster 0.13 and Appsec Blessed Python 3.9 #10
base: main
Are you sure you want to change the base?
Conversation
I'll update it all to 3.12 when I upgrade the dagster version - but first things first - just get the appsec image running old dagster
… the dockerfile logic correct
… psycopg2-binary, and pyyaml for dependency clashes
…Use temurin since adopt is now temurin, essentially
…" - but one of the devs suggested trying "2.0.1" snok/install-poetry#164
…eInProcessGraphResult - (migrating from 0.12.14 to 0.13) https://github.com/dagster-io/dagster/blob/4fb944ec6d0d9dfd57856901f5a43ea381483187/python_modules/dagster/dagster/core/execution/execute_in_process_result.py
…o generate the requirements file for the security scanners
…epth back to checkout
# formerly known as `service_account_key` | ||
credentials_json: '${{ secrets.GCP_TEST_KEY }}' | ||
- name: 'Set up Cloud SDK' | ||
uses: 'google-github-actions/[email protected]' |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
env: | ||
GCP_TEST_KEY: '${{ secrets.GCP_TEST_KEY }}' | ||
- name: 'Set up Cloud SDK' | ||
uses: 'google-github-actions/[email protected]' |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
…ion version - v2 is being deprecated
…ion version - v2 is being deprecated
…109-new-hca-dev-env
fetch-depth: 0 | ||
- id: 'auth' | ||
uses: 'google-github-actions/auth@v2' |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step: auth
# Needed by sonar to get the git history for the branch the PR will be merged into. | ||
with: | ||
fetch-depth: 0 | ||
- uses: google-github-actions/[email protected] | ||
- id: 'auth' | ||
uses: 'google-github-actions/auth@v2' |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step: auth
…tput_for_node, such that it was trying to find the output_value method in HcaScratchDatasetName. which does not have that method, rather than ExecuteInProcessResult, which does. The default value for output_value is result though, so this should perhaps resolve the issue. https://docs.dagster.io/api/python-api/execution dagster-io/dagster#6218
…109-new-hca-dev-env
…109-new-hca-dev-env
…109-new-hca-dev-env
Why
Relevant ticket
This PR
Checklist