Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ilyasoifer committed Feb 14, 2024
1 parent 0ce00d1 commit 80f0d4c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ public enum FLOW_DUPLICATE_SELECTION_STRATEGY {
@Argument(doc = "enable parameters and behavior specific to flow based reads.", optional = true)
public boolean FLOW_MODE = false;

@Argument(doc = "Use specific quality summing strategy for flow based reads. The strategy ensures that the same " +
"(and correct) quality value is used for all bases of the same homopolymer.", optional = true)
@Argument(doc = "Use specific quality summing strategy for flow based reads. Two strategies are available: " +
"FLOW_QUALITY_SUM_STRATEG: The selects the read with the best total homopolymer quality." +
" FLOW_END_QUALITY_STRATEGY: The strategy selects the read with the best homopolymer quality close to the end (10 bases) of the read. " +
" The latter strategy is recommended for samples with high duplication rate ", optional = true)
public FLOW_DUPLICATE_SELECTION_STRATEGY FLOW_DUP_STRATEGY = FLOW_DUPLICATE_SELECTION_STRATEGY.FLOW_QUALITY_SUM_STRATEGY;

@Argument(doc = "Make the end location of single end read be significant when considering duplicates, " +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public short getReadDuplicateScore(final SAMRecord rec, final ReadEndsForMarkDup
}
}

//This method is identical to areComparableForDuplicates but allow working with readStartUncertainty
//This method is identical to MarkDuplicates.areComparableForDuplicates but allows working with readStartUncertainty
protected boolean areComparableForDuplicates(final ReadEndsForMarkDuplicates lhs, final ReadEndsForMarkDuplicates rhs,
final boolean compareRead2, final boolean useBarcodes) {
boolean areComparable = lhs.libraryId == rhs.libraryId;
Expand Down

0 comments on commit 80f0d4c

Please sign in to comment.