Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3890] Add models.User.DeactivatedAt #683

Merged
merged 2 commits into from
Oct 9, 2024

update field comment

df35c65
Select commit
Loading
Failed to load commit list.
Merged

[DDO-3890] Add models.User.DeactivatedAt #683

update field comment
df35c65
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 8, 2024 in 0s

67.52% (-0.28%) compared to 9878ab0

View this Pull Request on Codecov

67.52% (-0.28%) compared to 9878ab0

Details

Codecov Report

Attention: Patch coverage is 79.03226% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.52%. Comparing base (9878ab0) to head (df35c65).

Files with missing lines Patch % Lines
sherlock/internal/api/sherlock/users_v3_list.go 70.00% 2 Missing and 1 partial ⚠️
sherlock/internal/models/role_assignment.go 66.66% 1 Missing and 2 partials ⚠️
...ock/internal/models/role_assignment_auto_delete.go 70.00% 2 Missing and 1 partial ⚠️
...k/internal/middleware/authentication/middleware.go 0.00% 2 Missing ⚠️
sherlock/internal/models/test_data.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   67.79%   67.52%   -0.28%     
==========================================
  Files         291      291              
  Lines       13535    13584      +49     
==========================================
- Hits         9176     9172       -4     
- Misses       3455     3519      +64     
+ Partials      904      893      -11     
Files with missing lines Coverage Δ
sherlock/internal/api/sherlock/users_v3.go 100.00% <100.00%> (ø)
sherlock/internal/boot/application.go 59.37% <100.00%> (ø)
...nternal/middleware/authentication/user_provider.go 21.51% <100.00%> (-15.25%) ⬇️
sherlock/internal/models/role_auto_assign.go 44.68% <100.00%> (ø)
sherlock/internal/models/user.go 89.24% <100.00%> (+2.43%) ⬆️
...k/internal/middleware/authentication/middleware.go 0.00% <0.00%> (-87.50%) ⬇️
sherlock/internal/models/test_data.go 98.05% <80.00%> (-0.17%) ⬇️
sherlock/internal/api/sherlock/users_v3_list.go 79.48% <70.00%> (-3.28%) ⬇️
sherlock/internal/models/role_assignment.go 81.29% <66.66%> (-0.91%) ⬇️
...ock/internal/models/role_assignment_auto_delete.go 53.33% <70.00%> (ø)

... and 1 file with indirect coverage changes