Get closest contiguous clickable element for hints to reduce duplicat… #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One issue with this implementation is that leaf elements can be swallowed up by the parent elements. An example of this is the per-email actions (star, selectbox on left side of each row) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e hints
Addresses #1448
SurfingKeys applies hints to any elements if they're clickable and visible. I modified SurfingKeys to find the furthest contiguous ancestor that is clickable. This significantly reduces duplicate hints, and should make it clearer what clickable region each hint actually refers to.
I experimented with deduplicating on the href, but that didn't seem to have much effect, and is excluded from this PR.