add support for trustStore and trustStorePassword #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,43 +26,42 @@ | |||
|
|
|||
| import org.apache.http.conn.ssl.SSLSocketFactory; | |||
|
|
|||
| import com.google.common.base.Throwables; | |||
There was a problem hiding this comment.
Is this file Copyright VMware, Inc, as it says at the top of the file?!
There was a problem hiding this comment.
I started from a VMware class, but I've completely re-written that. Removing the copyright
andreaturli
force-pushed
the
fix/truststore-usage
branch
from
51a97c4 to
160c1e3
Compare
|
|
||
| // Performing Certificate Validation | ||
| if (Strings.isNonBlank(trustStorePassword)) { | ||
| LOG.debug("Registering HTTPS scheme using trustStore ='{}' with trustStorePassword = '{}'", trustStore, trustStorePassword); |
There was a problem hiding this comment.
@aled, is it fine to log this password?
There was a problem hiding this comment.
Don't log the password; just log ******** instead of {}.
andreaturli
force-pushed
the
fix/truststore-usage
branch
from
a302827 to
49fe773
Compare
tbouron
force-pushed
the
master
branch
7 times, most recently
from
978d4df to
a7320d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aledsage can you take a look at it?