Fixes incorrect 'PublicIp a.b.c.d is not valid' in log when multiple gateways are present #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gateways are present
| @@ -549,37 +549,17 @@ private boolean includesPublicIp(final String publicIp, List<SubnetParticipation | |||
| return false; | |||
| } | |||
|
|
|||
| private void checkPublicIps(Iterable<String> publicIps, List<SubnetParticipationType> subnetParticipations) { | |||
| private boolean checkPublicIps(Iterable<String> publicIps, List<SubnetParticipationType> subnetParticipations) { | |||
There was a problem hiding this comment.
The naming convention of checkPublicIps follows the guava contention. The semantics elsewhere are that it will throw an exception if the check fails, rather than returning a boolean.
|
@nakomis could you update the PR? |
tbouron
force-pushed
the
master
branch
7 times, most recently
from
978d4df
to
a7320d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.