Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version to 2.6.0-SNAPSHOT #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andreaturli
Copy link

  • bump etcd version to 3.2.7

@aledsage @grkvlt can you please have a look at it? When I import the catalog.bom into my server I can see the following summary which looks wrong as it references some items with version 2.5.0

screen shot 2017-09-14 at 9 49 00 pm

- bump etcd version to 3.2.7
Copy link
Member

@m4rkmckenna m4rkmckenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaturli
Copy link
Author

thanks @m4rkmckenna any idea why I'm seeing that issue?

@aledsage
Copy link
Member

@andreaturli when I tried br catalog add catalog.bom, it worked. I got:

etcd-node:2.6.0-SNAPSHOT
etcd-proxy:2.6.0-SNAPSHOT
etcd-cluster:2.6.0-SNAPSHOT
etcd-cluster-template:2.6.0-SNAPSHOT

What's strange about that catalog.bom is that it adds the library https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=io.brooklyn.etcd&a=brooklyn-etcd&v=2.6.0-SNAPSHOT, and then adds the item from that jar's classpath of etcd/catalog.bom.

If you're testing the PR locally by doing br catalog add catalog.bom, then you won't be getting your changes tested. You'll be using whatever is at mvn sonatype snapshot, which will presumably be the the latest in master. However, I'm surprised that 2.6.0-SNAPSHOT existed in sonatype, given that your PR bumps the version number!

- remove brooklyn.libraries
- point to latest etcd/etc.bom file in Sonatype
@andreaturli
Copy link
Author

thanks @aledsage I've modified the catalog.bom to use directly the etcd.bom file available in Sonatype

@aledsage
Copy link
Member

aledsage commented Oct 2, 2017

@andreaturli thanks - the catalog.bom in master has changed so that we don't reference sonatype. Instead it uses the local file (expecting this entire compiled bundle to be added to brooklyn, rather than a standalone .bom file).

I suggest we first merge #22, and then rebase this PR against master and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants