[WIP] Configure TLS for Kubernetes services #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grkvlt
force-pushed
the
kubernetes-tls
branch
4 times, most recently
from
7a04f47
to
a709038
Compare
aledsage
reviewed
Oct 17, 2016
| default: | ||
| "classpath://io.brooklyn.clocker.kubernetes:kubernetes/basic_auth.csv" | ||
| "classpath://io.brooklyn.clocker.kubernetes:kubernetes/policy.jsonl" |
There was a problem hiding this comment.
Why is this file called .jsonl? Is that a typo?
There was a problem hiding this comment.
It's an awful format called JSON List which is a series of concatenated JSON objects!
aledsage
reviewed
Oct 17, 2016
| sudo mkdir /etc/kubernetes/certs | ||
| sudo chown ${USER} /etc/kubernetes/certs | ||
| source ${INSTALL_DIR}/certificate-functions.sh | ||
| getcert ${CA_REQUEST_ROOT_URL}/cacert/ca.pem /etc/kubernetes/certs/ca.pem |
There was a problem hiding this comment.
I'm a bit uncomfortable about this. It means the blueprint can't be used with an enterprise's existing CA server, if it does not support this REST api. I wonder if that could be customized by supplying your own certificate-functions.sh (but that script is not customizable).
This is probably a much bigger conversation though.
There was a problem hiding this comment.
Agree, but that is a change that should be applied to all entities in Clocker that use TLS and the CA server
grkvlt
force-pushed
the
kubernetes-tls
branch
5 times, most recently
from
ee4b8d5
to
c1a484c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.