Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add pub #55

Merged
merged 40 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
1e1f5d1
wip: add pub refactor
eldu Jan 24, 2024
b3318b6
refactor: delete actions, client, reducer, sagas
eldu Jan 24, 2024
5c58d0b
refactor: file renames
eldu Jan 24, 2024
e9ecc7d
build: npm uninstall keycloak-js, redux-saga
eldu Jan 24, 2024
401bc64
build: npm uninstall isomorphic-fetch
eldu Jan 24, 2024
021f848
Merge branch 'feat-lint' into feat-add-pub
eldu Jan 24, 2024
cc98b9f
refactor: add publication modal
eldu Feb 5, 2024
d735ef0
feat: add manual form
eldu Feb 5, 2024
5b82333
feat: add formik to manual form
eldu Feb 5, 2024
50f263f
refactor: error message for doi
eldu Feb 5, 2024
c61446a
refactor: transition of form
eldu Feb 5, 2024
a4ef47f
fix: initial Values
eldu Feb 5, 2024
3ab3ab3
feat: validation
eldu Feb 5, 2024
123b12d
style: required asterisk
eldu Feb 5, 2024
d233313
style: required asterisk
eldu Feb 5, 2024
09e03f3
refactor: restrict date
eldu Feb 5, 2024
b61ec57
feat: check against publications for exists
eldu Feb 5, 2024
d674550
fix: bugs
eldu Feb 5, 2024
6d5e67c
wip: add to firebase
eldu Feb 6, 2024
b716419
fix: error message
eldu Feb 6, 2024
168e3db
refactor: collection document structure
eldu Feb 6, 2024
c4aaed4
refactor: hook to watch publications collection
eldu Feb 6, 2024
9d9bb70
fix: undefines
eldu Feb 6, 2024
2540879
refactor: firebase utils
eldu Feb 6, 2024
a4149e4
doc: custom react hook
eldu Feb 6, 2024
9e55f3b
fix: css UGH
eldu Feb 6, 2024
d95e1a9
refactor: remove unused util function
eldu Feb 6, 2024
091be9e
refactor: remove html tags in abstract
eldu Feb 6, 2024
9755c85
refactor: types file
eldu Feb 6, 2024
7b5dbce
refactor: linting
eldu Feb 6, 2024
b06aa57
refactor: remove import
eldu Feb 6, 2024
7f4ea58
feat: loading
eldu Feb 6, 2024
fedfdaa
refactor: delete old files
eldu Feb 6, 2024
0ab4ee4
refactor: small things
eldu Feb 6, 2024
c4d2ff2
refactor: form control feedback and some refactor
eldu Feb 6, 2024
4d840ef
refactor: move usePublicationsCollection up the hierarchy
eldu Feb 7, 2024
7ff9039
refactor: move usePublicationsCollection up the hierarchy
eldu Feb 7, 2024
05002cf
doc: add in a todo for pagination
eldu Feb 7, 2024
a4cab04
feat: adds in date stuff
eldu Feb 7, 2024
c702ab0
fix: pr review - add s and fix date stuff
eldu Feb 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ npm-debug.log*
yarn-debug.log*
yarn-error.log*

keycloak.json
serviceAccount.json

# checkpoints
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ npm-debug.log*
yarn-debug.log*
yarn-error.log*

keycloak.json
firebase.json

# checkpoints
Expand Down
395 changes: 207 additions & 188 deletions package-lock.json

Large diffs are not rendered by default.

15 changes: 7 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
"private": true,
"homepage": ".",
"scripts": {
"start": "react-scripts --openssl-legacy-provider start",
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --testPathPattern=src/tests/unit",
"eject": "react-scripts eject",
"format": "prettier --write .",
"lint": "eslint --ext .ts,.js,.jsx src --fix",
"lint": "eslint --ext .ts,.js,.jsx,.tsx src types --fix",
"prepare": "husky install"
},
"dependencies": {
Expand All @@ -21,8 +21,7 @@
"bootstrap": "^5.3.2",
"brown-university-styles": "git+https://github.com/BrownUniversity/brown-university-styles.git",
"firebase": "^10.7.2",
"isomorphic-fetch": "^3.0.0",
"keycloak-js": "^9.0.2",
"formik": "^2.4.5",
"lodash": "^4.17.11",
"react": "^18.2.0",
"react-bootstrap": "^2.9.2",
Expand All @@ -35,13 +34,13 @@
"react-table": "^6.10.0",
"reactstrap": "^9.2.1",
"redux": "^5.0.1",
"redux-saga": "^1.3.0",
"sass": "^1.69.7",
"seamless-immutable": "^7.1.4",
"table": "^5.4.1",
"vega": "^5.27.0",
"vega-embed": "^6.24.0",
"vega-lite": "^5.16.3"
"vega-lite": "^5.16.3",
"yup": "^1.3.3"
},
"devDependencies": {
"@brown-ccv/eslint-config": "^0.3.0",
Expand All @@ -64,9 +63,9 @@
},
"prettier": "@brown-ccv/prettier-config",
"lint-staged": {
"src/**/*.{js,jsx,ts,tsx,json,css,scss,md}": [
"src/**/*.{js,jsx,ts,tsx}": [
"prettier --write .",
"eslint --ext .ts,.js,.jsx src --fix"
"eslint --ext .ts,.js,.jsx,.tsx src types --fix"
]
},
"browserslist": {
Expand Down
8 changes: 3 additions & 5 deletions src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,18 @@ import Navbar from './components/react-ccv-components/Navbar';
import Footer from './components/react-ccv-components/Footer';

import { ContentPage } from './components/ContentPage';

// TODO: Ignoring for now because it's to be refactored
// eslint-disable-next-line import/no-named-as-default
import AddPub from './components/AddPub';
import { usePublicationsCollection } from './utils/firebase.ts';

export function App() {
usePublicationsCollection();

return (
<div aria-live="polite">
<Navbar />
<div className="App">
<BrowserRouter>
<main>
<Routes>
<Route path="/addpub" className="AddPub" element={<AddPub />} />
<Route exact path="/" element={<ContentPage />} />
</Routes>
</main>
Expand Down
59 changes: 0 additions & 59 deletions src/actions.js

This file was deleted.

112 changes: 0 additions & 112 deletions src/client.js

This file was deleted.

Loading
Loading