Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix routes display main #24

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Fix routes display main #24

merged 4 commits into from
Dec 3, 2024

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Dec 2, 2024

Firebase was previously re-routing everything to /index.html (my mistake -- copied from another proj); this caused ALL routes in prod to get replaced with the home page content. Redid the firebase hosting config to fix

Copy link

github-actions bot commented Dec 2, 2024

Visit the preview URL for this PR (updated for commit a1fa7ec):

https://ccv-website-next--pr24-fix-routes-display-m-4admka8d.web.app

(expires Mon, 09 Dec 2024 20:54:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 809aa2d3a6cfe026c3c7417c932015a8f1d9ec89

@hetd54 hetd54 self-assigned this Dec 2, 2024
Copy link
Collaborator

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING! Thanks so much heather !

Copy link
Collaborator

@anna-murphy anna-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I did notice that it looks like there's some darkmode stuff happening on some of these routes. Obvs, that's not for this PR, but I just wanted to make sure this is on your radar...
image
(Edit: the nav text is white for some reason)

@hetd54 hetd54 merged commit 21a4af8 into main Dec 3, 2024
2 checks passed
@hetd54 hetd54 deleted the fix-routes-display-main branch December 3, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants