feat: Export getSearchParam and update login fields based on it #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit c32caf6): https://ccv-honeycomb--pr334-ref-urlsearchparams-yo2eh8ak.web.app (expires Wed, 13 Dec 2023 14:57:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
RobertGemmaJr
requested review from
digicosmos86,
eldu,
anna-murphy,
tdivoll and
hetd54
eldu
reviewed
Nov 30, 2023
src/App/App.jsx
Outdated
Comment on lines
95
to
96
| if (maybeStudyID != null) setStudyID(maybeStudyID); | ||
| if (maybeParticipantID != null) setParticipantID(maybeParticipantID); |
There was a problem hiding this comment.
Strict inequality?
Suggested change
| if (maybeStudyID != null) setStudyID(maybeStudyID); | |
| if (maybeParticipantID != null) setParticipantID(maybeParticipantID); | |
| if (maybeStudyID !== null) setStudyID(maybeStudyID); | |
| if (maybeParticipantID !== null) setParticipantID(maybeParticipantID); |
Comment on lines
+15
to
+24
| // Update local participantID if it changes upstream | ||
| useEffect(() => { | ||
| setParticipantID(initialParticipantID); | ||
| }, [initialParticipantID]); | ||
|
|
||
| // Update local studyID if it changes upstream | ||
| useEffect(() => { | ||
| setStudyID(initialStudyID); | ||
| }, [initialStudyID]); | ||
|
|
There was a problem hiding this comment.
Why would it change upstream?
There was a problem hiding this comment.
I query parameters weren't auto-filling without these useEffect. I think it's because the state in App.jsx wasn't being set on the first render. I don't imagine folks will change the search parameters but if they do it will change the login fields which I think is nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The login page is now automatically filled out if
studyIDandparticipantIDare in the URLSearchParamsgetQueryVariableasgetSearchParamgetSearchParamis now exported and used to readstudyIDandparticipantIDfrom the URLSearchParams<Login />generateWaitSetfunction as it's unusedcloses #199