Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add photodiodeGhostBox and pdSpotEncode to fixation and honeycomb trials #356

Merged
merged 78 commits into from
Dec 13, 2023
Merged

feat: Add photodiodeGhostBox and pdSpotEncode to fixation and honeycomb trials #356

merged 78 commits into from
Dec 13, 2023

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented Dec 12, 2023 •
edited
Loading

  • Adds photodidoeGhostBox as the prompt for fixation and honeycomb trials
  • Adds pdSpotEncode to the on_load callback of the fixation and honeycomb trials

@RobertGemmaJr
ref: Renames photodiodeSpot and pdSpotEncode
2ff0b89 
This was the original name of function. Returning to that name as it's more prescriptive, will wait to change until the bigger change in v4
@RobertGemmaJr
ref: Export photodiodeGhostBox as a constant, not a function
73c6178
@RobertGemmaJr
chore: TODO
9b60a97
@RobertGemmaJr
chore: TODO number
3e361ac
@RobertGemmaJr
Merge branch 'chore-issues' into ref-photodiode_spot
68c7f4b
@RobertGemmaJr
chore: TODO numbers
e84cb53
@RobertGemmaJr
Merge branch 'main' into ref-photodiode_spot
850a0c8
@RobertGemmaJr
wip: Add fixation code directly to Honeycomb
f279d65
@RobertGemmaJr
wip: Fixation trial uses global config object
eb251a3
@RobertGemmaJr
wip: Fixation uses helper function for creating the stimulus
1886738
@RobertGemmaJr
chore: TODO
c9a9046
@RobertGemmaJr
chore: TODOs for trigger code
91b2f36
@RobertGemmaJr
ref: Clean up trigger codes
57a5f6d
@RobertGemmaJr
wip: Cleanup debrief trial
06d0659
@RobertGemmaJr
ref: Rename task names
229f255
@RobertGemmaJr
ref: Rename functions from create_ to build_
3f391cf
@RobertGemmaJr
Merge branch 'ref-jsPsychExperiment' into ref-fixation
524a511
@RobertGemmaJr
chore: Docstrings for triggerbox settings
65b76ae
@RobertGemmaJr
ref: Defaults productID to undefined
6b48841
@RobertGemmaJr
ref: Hard code audio code
167fffc
@RobertGemmaJr
chore: Comments
dd7a0f2
@RobertGemmaJr
chore: Remove TODO
29935ff
@RobertGemmaJr
chore: TODOs
0ed2e8e
@RobertGemmaJr
chore: comments
31ad539
@RobertGemmaJr
chore: comments
61ac47e
@RobertGemmaJr
chore: docstring
f78f795
@RobertGemmaJr
wip: Add fixation code directly to Honeycomb
222742b
@RobertGemmaJr
wip: Fixation trial uses global config object
8203af6
@RobertGemmaJr
wip: Fixation uses helper function for creating the stimulus
16ebef1
@RobertGemmaJr
chore: TODO
41c4c05
@RobertGemmaJr RobertGemmaJr self-assigned this Dec 12, 2023
@RobertGemmaJr RobertGemmaJr marked this pull request as ready for review December 12, 2023 16:36
@RobertGemmaJr RobertGemmaJr linked an issue Dec 13, 2023 that may be closed by this pull request
Add Photodiode spot and event marker code for the demo task #332
Closed
Base automatically changed from ref-fixation to hold-cleaning December 13, 2023 20:04
@RobertGemmaJr RobertGemmaJr merged commit 2b66923 into hold-cleaning Dec 13, 2023
1 of 2 checks passed
@RobertGemmaJr RobertGemmaJr deleted the feat-photodiodeGhostBox branch December 13, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RobertGemmaJr RobertGemmaJr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Photodiode spot and event marker code for the demo task
1 participant
@RobertGemmaJr