Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Honeycomb v3.3.0 #377

Merged
merged 341 commits into from
Mar 25, 2024
Merged

feat: Honeycomb v3.3.0 #377

merged 341 commits into from
Mar 25, 2024

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented Jan 10, 2024

Note that this PR is bringing all of the previous changes into main, feat-v3.3 is just a holding branch. All of the code has been looked at in other PRs. 3.3 is just about ready to be released!

What's Changed

Electron

  • The electron forge configuration is moved to forge.config.js
  • A preload script is added to bridge between the Electron and renderer processes
  • Mac is now packaged for the universal binary
  • Electron is updated to its latest version

Firebase

The default Firestore rules now allow any participantID and studyID combination to be used at runtime. This is how all of the labs have been using their Firebase so I figured it should stay. The previous rules (the studyID and participantID must be registered somewhere else in the Firestore) are present but commented out

Experiment

  • All experiment code is moved to src/experiment
  • The photodiodeGhostBox is always added as the prompt of the trial
  • The pdSpotEncode function is always called on on_load callback of the trial
  • All trials are now written in the "jsPsych way" instead of using custom code
  • blocks are now referred to as procedures

Miscellaneous

  • Adds a Content-Security Policy
  • no-unused-vars is now a warning with eslint
  • Any eslint warnings will now fail the github actions
  • Adds the Honeycomb hexagon icon to the project in all of its needed forms
  • Deletes the unit tests for the utility functions
  • Uses inline exports
  • Prefer function(){} over callback functions
  • Rewrites all TODO's to include @brown-ccv

RobertGemmaJr and others added 30 commits November 7, 2023 14:11
Variable was not used on the renderer
I've been having some issues with the app.isPackaged?
@RobertGemmaJr RobertGemmaJr requested review from digicosmos86, broarr, eldu, anna-murphy and galenwinsor and removed request for digicosmos86 March 12, 2024 20:41
@RobertGemmaJr RobertGemmaJr marked this pull request as ready for review March 12, 2024 20:42
Copy link

@broarr broarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too big for me to provide a good review. I skimmed the code and didn't see anything glaring

@RobertGemmaJr RobertGemmaJr merged commit 92b3187 into main Mar 25, 2024
8 checks passed
@RobertGemmaJr RobertGemmaJr deleted the feat-v3.3 branch March 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3 Versioning: Issue in regards to version 3.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants