Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional info to repo, data #479

Merged
merged 22 commits into from
Jul 31, 2024
Merged

feat: Add additional info to repo, data #479

merged 22 commits into from
Jul 31, 2024

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented May 16, 2024

  • Adds PACKAGE_NAME and PACKAGE_VERSION to import.meta.env in all processes
  • Adds PACKAGE_NAME to jsPsych data object as app_name
  • Adds PACKAGE_VERSION to jsPsych data object as app_version
  • Removes taskVersion and taskName from config.js
  • Re-orders the appearance of app related data in the jsPsych data object (important for .csv downloads)

Git Versioning

  • Honeycomb now checks the git sha & ref at runtime while in development
  • The logic for handling the the git sha & ref in the built application is the same
  • The git information is passed directly into the jsPsych data object as app_commit

Note that in order to get this to work I had to change the useMemo to be an async useEffect when building the jsPsych class. I'd definitely like to move that code to the onSubmit of the login form but I'll tackle that in another PR

@RobertGemmaJr RobertGemmaJr self-assigned this May 16, 2024
@RobertGemmaJr RobertGemmaJr changed the base branch from main to ref-version May 16, 2024 21:11
Copy link

github-actions bot commented May 16, 2024

Visit the preview URL for this PR (updated for commit a6802ba):

https://ccv-honeycomb--pr479-ref-info-o7vq731h.web.app

(expires Wed, 07 Aug 2024 14:11:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@RobertGemmaJr RobertGemmaJr changed the base branch from ref-version to feat-forge-vite May 16, 2024 21:15
Base automatically changed from feat-forge-vite to feat-v4 May 17, 2024 19:24
@RobertGemmaJr RobertGemmaJr requested a review from YUUU23 June 13, 2024 20:28
@RobertGemmaJr RobertGemmaJr linked an issue Jul 12, 2024 that may be closed by this pull request
Copy link
Contributor

@YUUU23 YUUU23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with moving initialization of the jsPsych object for each experiment to onSubmit on the login form. If I am understanding the intention correctly, I agree it makes more sense to init the experiment when submit is clicked.

Also, I was wondering about the idea if we could possibly have a getSHA and maybe getRef function to retrieve those values (would be used in getCommit function for Electron/main.js and versions.js) inside utilities functions so we can also use the same helper functions to retrieve and write GIT SHA to firebase?

@RobertGemmaJr RobertGemmaJr mentioned this pull request Jul 31, 2024
@RobertGemmaJr RobertGemmaJr merged commit fdc5b20 into feat-v4 Jul 31, 2024
8 checks passed
@RobertGemmaJr RobertGemmaJr deleted the ref-info branch July 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write git sha to Firebase, remove deprecated information
2 participants