-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add additional info to repo, data #479
Conversation
Visit the preview URL for this PR (updated for commit a6802ba): https://ccv-honeycomb--pr479-ref-info-o7vq731h.web.app (expires Wed, 07 Aug 2024 14:11:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with moving initialization of the jsPsych
object for each experiment to onSubmit
on the login form. If I am understanding the intention correctly, I agree it makes more sense to init the experiment when submit is clicked.
Also, I was wondering about the idea if we could possibly have a getSHA
and maybe getRef
function to retrieve those values (would be used in getCommit
function for Electron/main.js
and versions.js
) inside utilities functions so we can also use the same helper functions to retrieve and write GIT SHA
to firebase?
PACKAGE_NAME
andPACKAGE_VERSION
toimport.meta.env
in all processesPACKAGE_NAME
to jsPsych data object asapp_name
PACKAGE_VERSION
to jsPsych data object asapp_version
taskVersion
andtaskName
fromconfig.js
.csv
downloads)Git Versioning
app_commit
Note that in order to get this to work I had to change the
useMemo
to be an asyncuseEffect
when building the jsPsych class. I'd definitely like to move that code to theonSubmit
of the login form but I'll tackle that in another PR