Ref event codes json #519
Merged
Ref event codes json #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9cc4fb6): https://ccv-honeycomb--pr519-ref-event-codes-json-w7985hfa.web.app (expires Tue, 06 Aug 2024 05:00:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
This will happen automatically! When |
|
Actually, @YUUU23 it looks like this branch should be going into ref-config-as-ENV? |
Yes! I will change this. |
YUUU23
requested review from
RobertGemmaJr
and removed request for
RobertGemmaJr
RobertGemmaJr
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved
eventCodesinto its own json filechange import/export in
trigger.jsaccordinglyshould we rename the final export in
trigger.jsEVENT_CODESinstead ofeventCodes? Also not entirely sure if we want to name this fileconfig.jsonas mentioned in the issue oreventCodes.jsonmerged into
ref-config-env-idxsince a lot of the changes there are related to this modification; this branch was also based onref-config-env-idx. This can also be changed to base onv4branch if needed.