Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port marian to WASM for inference #24
Port marian to WASM for inference #24
Changes from all commits
fd4989e
efe2c09
80ec1a8
ab29cbc
6b95d31
773d565
b11cd34
f00909e
310cba7
c3492d3
179b8e6
caf07b3
5dafba9
a7ee4a1
230c4d9
9d7767b
d2dbf9d
ece499d
08f2b79
4d1de8c
769e229
dcbcb35
3c8a34f
2b7f788
9d2d55a
dd3c24f
900184d
3064e36
e516a37
2ca2a23
25a200e
68b516a
9802096
2344432
cc77573
3223a50
f5cbbbb
4012fe0
c3fa3a2
5ecfd6c
79009b5
f2f8694
db82d12
765f830
92132b9
ecd063e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit could have been outside the if statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun fact: now that @XapaJIaMnu has binary working, you can get rid of cnpy entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but for compilation we will still have to keep this ifdef. Right?