Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binarize QE models and make tool to do that #53

Open
kpu opened this issue Jan 27, 2022 · 1 comment
Open

Binarize QE models and make tool to do that #53

kpu opened this issue Jan 27, 2022 · 1 comment
Assignees

Comments

@kpu
Copy link
Member

kpu commented Jan 27, 2022

@mfomicheva e-mailed some JSON files which I have now checked in: 962d419

As @mfomicheva wrote in a follow up, these need to be binarized. The documentation refers to this thing:

https://github.com/abarbosa94/bergamot-translator/blob/quality-estimator-update/src/tests/units/quality_estimator_tests.cpp#L43

Can we get a proper tool for that? It doesn't have to be a full-on JSON parsing thing, but the values shouldn't be hard-coded in the C++. Binarized models are more important though.

@kpu
Copy link
Member Author

kpu commented Feb 17, 2022

@mfomicheva Thanks for the repo https://github.com/browsermt/quality-estimation with QE training and soon the binarizer.

@felipesantosk @mfomicheva Can you binarize the 3 JSON files and submit a PR to this repo (students) with the binary files? (One of them is done already.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants