Fix non-root hosts failing on resolving DNS #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same-id
force-pushed
the
fix-non-root-hosts
branch
3 times, most recently
from
0b754dc to
6cca6f1
Compare
|
Thanks for looking into this. |
same-id
force-pushed
the
fix-non-root-hosts
branch
from
6cca6f1 to
a267609
Compare
|
Fixed |
same-id
force-pushed
the
fix-non-root-hosts
branch
from
a267609 to
ed7d971
Compare
guggero
reviewed
Oct 28, 2024
same-id
force-pushed
the
fix-non-root-hosts
branch
from
ed7d971 to
c7dae61
Compare
|
gentle bump - reminding that ATM btcd@master is broken with providers like quicknode |
Pull Request Test Coverage Report for Build 12174808993Details
💛 - Coveralls |
guggero
reviewed
Nov 7, 2024
There was a problem hiding this comment.
I think we should clean this up a bit more and add some basic tests.
Here's my proposal as a diff (feel free to just use in your commit, no attribution required):
proposal.diff.txt
same-id
force-pushed
the
fix-non-root-hosts
branch
from
c7dae61 to
47faac8
Compare
Thanks for the review, still pending approval from another reviewer: @Crypt-iQ |
|
@guggero - just making sure we are really waiting for an additional reviewer here |
|
Hi, @guggero Gentle ping This is still stuck on review |
|
cc @yyforyongyu |
yyforyongyu
approved these changes
Dec 4, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
force-pushed
the
fix-non-root-hosts
branch
from
47faac8 to
42d6eba
Compare
|
Still blocked on merge |
yyforyongyu
approved these changes
Dec 5, 2024
yyforyongyu
approved these changes
Dec 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for a bug introduced by #2168
Previously, config.Host worked in the following way:
Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well.
However, this was the way it worked.
This PR solves this behavior while maintaining support of the "unix://" flow as well.
For some reason, "scheme" is named "network" in #2168 - I did not change that.
Also, remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
Also see: #2253