wallet: downgrade spew log to debug and limit its size
#905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Jan 25, 2024
This commit removes using `spew` on production as the tx log can be extremely large.
yyforyongyu
force-pushed
the
fix-logging
branch
from
1b81bb1
to
100327c
Compare
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
wallet: downgrade `spew` log to debug and limit its size
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
wallet: downgrade `spew` log to debug and limit its size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes using
spewon production as the tx log can be extremely large. For instance, when running this build the CI crashed because of this test, that also caused my local terminal to crash, because we are printing a very large invalid tx.