Skip to content

Commit

Permalink
[BUGFIX] Strictify bootstrap structure vh
Browse files Browse the repository at this point in the history
  • Loading branch information
@buepro
buepro committed Mar 28, 2024
1 parent e86eff3 commit 3aa4bb5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ public function render()
$this->tagName = $arguments['tagName'];
$this->tag->setTagName($arguments['tagName']);
$gutter = StructureVariantsUtility::getVectorProperty($arguments['gutter']);
$multiplier = ColumnVariantsUtility::getMultiplier($arguments['class'], $arguments['rowClass'], $arguments['count']);
$multiplier = ColumnVariantsUtility::getMultiplier(
$arguments['class'] ?? '', $arguments['rowClass'] ?? 'row-cols-1', $arguments['count'] ?? 1);

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 7.4, 5.7) 

Offset 'class' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 7.4, 5.7) 

Offset 'count' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 7.4, 5.7) 

Offset 'rowClass' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.0, 5.7) 

Offset 'class' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.0, 5.7) 

Offset 'count' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.0, 5.7) 

Offset 'rowClass' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.1, 5.7) 

Offset 'class' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.1, 5.7) 

Offset 'count' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.1, 5.7) 

Offset 'rowClass' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.1, 8.0) 

Offset 'class' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.1, 8.0) 

Offset 'count' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.1, 8.0) 

Offset 'rowClass' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.2, 8.0) 

Offset 'class' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.2, 8.0) 

Offset 'count' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 70 in Classes/ViewHelpers/Render/Bootstrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.2, 8.0) 

Offset 'rowClass' on array{tagName: string, gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.
$correction = StructureVariantsUtility::getVectorProperty($arguments['correction']);
$modifier = (new VariantsModifier())
->setMargins(VectorUtility::negate($gutter))
Expand Down
3 changes: 2 additions & 1 deletion Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ public static function renderStatic(
*/
if ($GLOBALS['TSFE'] instanceof TypoScriptFrontendController) {
$gutter = StructureVariantsUtility::getVectorProperty($arguments['gutter']);
$multiplier = ColumnVariantsUtility::getMultiplier($arguments['class'], $arguments['rowClass'], $arguments['count']);
$multiplier = ColumnVariantsUtility::getMultiplier(
$arguments['class'] ?? '', $arguments['rowClass'] ?? 'row-cols-1', $arguments['count'] ?? 1);

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 7.4, 5.7) 

Offset 'class' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 7.4, 5.7) 

Offset 'count' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 7.4, 5.7) 

Offset 'rowClass' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.0, 5.7) 

Offset 'class' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.0, 5.7) 

Offset 'count' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.0, 5.7) 

Offset 'rowClass' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.1, 5.7) 

Offset 'class' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.1, 5.7) 

Offset 'count' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^11, 8.1, 5.7) 

Offset 'rowClass' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.1, 8.0) 

Offset 'class' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.1, 8.0) 

Offset 'count' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.1, 8.0) 

Offset 'rowClass' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.2, 8.0) 

Offset 'class' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.2, 8.0) 

Offset 'count' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.

Check failure on line 82 in Classes/ViewHelpers/Structure/Wrap/ColumnViewHelper.php

View workflow job for this annotation

GitHub Actions / Build PHP (^12, 8.2, 8.0) 

Offset 'rowClass' on array{gutter: array|float, class: string, rowClass: string, count: int, correction: array|float} on left side of ?? always exists and is not nullable.
$correction = StructureVariantsUtility::getVectorProperty($arguments['correction']);
$modifier = (new VariantsModifier())
->setMargins(VectorUtility::negate($gutter))
Expand Down

0 comments on commit 3aa4bb5

Please sign in to comment.