Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require astunparse for older python versions #1198

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Require astunparse for older python versions #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
validate-email>=1.3
Jinja2>=2.11.1
protobuf>=5.27.0
astunparse>=1.6.3
astunparse>=1.6.3; python_version<"3.10"
7 changes: 6 additions & 1 deletion python/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,19 @@ classifiers =
Programming Language :: Python :: 3.6
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Programming Language :: Python :: 3.13

[options]
packages = find:
install_requires =
validate-email>=1.3
Jinja2>=2.11.1
protobuf>=5.27.0
astunparse>=1.6.3
astunparse>=1.6.3; python_version<"3.10"
python_requires = >=3.6

[options.data_files]
Expand Down
4 changes: 2 additions & 2 deletions tests/harness/python/requirements_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@

with open('python/requirements.in', 'r') as reqs:
lines = reqs.readlines()
requirements_dot_in_set = {line.strip() for line in lines if line.strip() and not line.startswith("#")}
requirements_dot_in_set = {line.strip('\n') for line in lines if line.strip() and not line.startswith("#")}

config = configparser.ConfigParser()
config.read('python/setup.cfg')
setup_dot_cfg_set = {line for line in config['options']['install_requires'].split() if not line.startswith("#")}
setup_dot_cfg_set = {line for line in config['options']['install_requires'].split('\n') if line and not line.startswith("#")}

assert requirements_dot_in_set == setup_dot_cfg_set
Loading