test(smtp): cover RSET

src/Traffic/Dispatcher/Smtp.php

@@ -51,9 +51,6 @@ public function dispatch(StreamClient $stream): iterable
                 $stream->sendData($this->createResponse(self::CLOSING));
                 $stream->disconnect();
                 return;
-            } elseif (\str_starts_with($response, 'RSET')) {
-                $stream->sendData($this->createResponse(self::OK));
-                $protocol = [];
             } elseif (\str_starts_with($response, 'DATA')) {
                 $stream->sendData($this->createResponse(self::START_MAIL_INPUT));
                 $message = $this->parser->parseStream($protocol, $stream);

tests/Unit/Traffic/Dispatcher/SmtpTest.php

@@ -21,13 +21,42 @@ public function testDispatchOneMail(): void
         $stream = StreamClientMock::createFromGenerator($this->mailMe(quit: true));
 
         $this->runInFiber(static function () use ($stream): void {
+            $cnt = 0;
             foreach ((new Smtp())->dispatch($stream) as $frame) {
                 self::assertInstanceOf(SmtpFrame::class, $frame);
                 self::assertSame('Test email', $frame->message->getSubject());
-                return;
+                ++$cnt;
             }
 
-            self::fail('No frame was yielded.');
+            self::assertSame(1, $cnt, 'Only one frame should be yielded.');
+        });
+    }
+
+    public function testDispatchOneMailWithRset(): void
+    {
+        $stream = StreamClientMock::createFromGenerator((function (\Generator ...$generators) {
+            yield "EHLO\r\n";
+            yield "MAIL FROM: <[email protected]>\r\n";
+            yield "RCPT TO: <[email protected]>\r\n";
+            yield "RCPT TO: <[email protected]>\r\n";
+            yield "RSET\r\n";
+            yield from $this->mailMe('Test email');
+        })());
+
+        $this->runInFiber(static function () use ($stream): void {
+            $cnt = 0;
+            foreach ((new Smtp())->dispatch($stream) as $frame) {
+                self::assertInstanceOf(SmtpFrame::class, $frame);
+                self::assertSame("Test email", $frame->message->getSubject());
+                self::assertSame(
+                    ['[email protected]', '[email protected]'],
+                    $frame->message->getProtocol()['BCC'],
+                    'RSET should clear the buffered data.',
+                );
+                ++$cnt;
+            }
+
+            self::assertSame(1, $cnt, 'Only one frame should be yielded.');
         });
     }
 
@@ -64,6 +93,7 @@ private function mailMe(string $subject = 'Test email', bool $quit = false): \Ge
         yield "MAIL FROM: <[email protected]>\r\n";
         yield "RCPT TO: <[email protected]>\r\n";
         yield "RCPT TO: <[email protected]>\r\n";
+        yield "NOOP\r\n";
         yield "DATA\r\n";
         yield "From: [email protected]\r\n";
         yield "To: [email protected]\r\n";
@@ -72,6 +102,7 @@ private function mailMe(string $subject = 'Test email', bool $quit = false): \Ge
         yield "\r\n";
         yield "Hello, this is a test email.\r\n";
         yield ".\r\n";
+        yield "NOOP\r\n";
         if ($quit) {
             yield "QUIT\r\n";
         }