Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Senders lazy #158

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Make Senders lazy #158

merged 1 commit into from
Jan 23, 2025

Conversation

roxblnfk
Copy link
Member

What was changed

All the senders now are created when needed

Why?

To avoid creating unnecessary directories during ***toFile senders initialization

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 23.27%. Comparing base (1bb7bcf) to head (4b96984).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Command/Run.php 0.00% 5 Missing ⚠️
src/Sender/SenderRegistry.php 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     23.31%   23.27%   -0.04%     
+ Complexity     1344     1343       -1     
============================================
  Files           159      159              
  Lines          4354     4348       -6     
============================================
- Hits           1015     1012       -3     
+ Misses         3339     3336       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit f971f65 into master Jan 23, 2025
23 of 27 checks passed
@roxblnfk roxblnfk deleted the lazy-services branch January 23, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant