Strict rules for cs fixer #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert src/Test/Proto
Revert src/Test/Proto
roxblnfk
reviewed
May 10, 2024
roxblnfk
reviewed
May 10, 2024
| string $content, | ||
| string $expectedResponsePrefix, | ||
| ): void { | ||
| if ($content !== '') { | ||
| \socket_write($socket, $content); | ||
| // print green "hello" string in raw console markup | ||
| $output->write( | ||
| '> ' . \str_replace(["\r", "\n"], ["\e[32m\\r\e[0m", "\e[32m\\n\e[0m"], $content), |
There was a problem hiding this comment.
The previous linter added spaces here. Now this removes ones :D
There was a problem hiding this comment.
Per 2 rule adds spaces, PhpCsFixer rule removes, which is better?
roxblnfk
reviewed
May 10, 2024
Comment on lines
+16
to
+18
| /** | ||
| * @var int<1, 65535> | ||
| */ |
There was a problem hiding this comment.
Is it possible to allow inline type hint for class properties?
There was a problem hiding this comment.
Only hint that duplicate class properties are removed.
roxblnfk
reviewed
May 10, 2024
Comment on lines
76
to
+78
| * @param positive-int $possibleBytes Maximum number of bytes to read. If the read fragment is longer than this | ||
| * an exception will be thrown. Default is 10MB | ||
| * an exception will be thrown. Default is 10MB | ||
| * |
There was a problem hiding this comment.
We align comments with the word @param
There was a problem hiding this comment.
This rule cannot be changed, only left or vertical
|
Thank you. You helped compile the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.