Skip to content

Commit

Permalink
update assertions with patchy coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
gingerbenw committed Jul 13, 2023
1 parent be45b49 commit 0974e0a
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions test/browser/features/resource-load-spans.feature
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,18 @@ Feature: Resource Load Spans
And the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" string attribute "http.url" matches the regex "^http:\/\/.*:[0-9]{4}\/favicon\.png\?height=100&width=100$"
And the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" string attribute "http.flavor" equals "1.1"

# Image status code and body size have very patchy browser coverage
And if present, the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.status_code" equals 200
And if present, the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length" equals 2202
And if present, the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length_uncompressed" equals 2202
# Image status code and body size have patchy browser coverage
And on Chrome versions >= 109:
"""
the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.status_code" equals 200
"""

# Actually Safari 16.4 but our test devices currently use 16.3, this can be dropped to 16 when the devices update
And on Chrome versions >= 54, Android versions >= 54, Safari versions >= 17, iOS versions >= 17, Firefox versions >= 45, Edge versions >= 17:
"""
the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length" equals 2202
the trace payload field "resourceSpans.0.scopeSpans.0.spans.1" integer attribute "http.response_content_length_uncompressed" equals 2202
"""

@skip_on_npm_build
@requires_resource_load_spans
Expand Down

0 comments on commit 0974e0a

Please sign in to comment.