Modernise browser packages #2224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
changed the title
gingerbenw
force-pushed
the
integration/typescript
branch
2 times, most recently
from
0b18a5e to
25ca84e
Compare
gingerbenw
changed the title
gingerbenw
force-pushed
the
integration/typescript
branch
from
4d6971c to
eade9df
Compare
node: TypeScript and rollup
core: move tests from src to test
core: move to src, add TypeScript and rollup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core: use dist assets for root export
|
|
||
| if (typeof exportValue === 'string') { | ||
| targetFilePath = exportKey.endsWith('*') | ||
| ? exportValue.replace( |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 1 day ago
To fix the problem, we need to ensure that all occurrences of the asterisk (*) in exportValue are replaced with the appropriate substring of submoduleName. This can be achieved by using a regular expression with the global flag (g) in the replace method.
- Change the
replacemethod call on line 146 to use a regular expression with the global flag. - Ensure that the replacement logic remains the same, i.e., replacing the asterisk (
*) with the appropriate substring ofsubmoduleName.
Suggested changeset
1
jest/node-exports-resolver.js
| @@ -146,3 +146,3 @@ | ||
| ? exportValue.replace( | ||
| /\*/, submoduleName.slice(exportKey.length - 1) | ||
| /\*/g, submoduleName.slice(exportKey.length - 1) | ||
| ) |
Copilot is powered by AI and may make mistakes. Always verify output.
This reverts commit 50bebe4.
drop @bugsnag/core/breadcrumb export
…s into integration/typescript
drop @bugsnag/core/(client|event|session) exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert packages to TypeScript using rollup to bundle both ES modules and Common JS modules for maximum compatibility
Changeset
Testing
Covered by CI
Outstanding