Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin concurrent-ruby to 1.3.4 in react-native fixtures #2282

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Pin concurrent-ruby to 1.3.4 in react-native fixtures #2282

merged 1 commit into from
Jan 17, 2025

Conversation

gingerbenw
Copy link
Member

Goal

Fix failing iOS build due to latest concurrent-ruby release dropping requirement for logger

@github-actions GitHub Actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 3b9003e

@gingerbenw gingerbenw marked this pull request as ready for review January 17, 2025 09:13
joshedney
joshedney approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@joshedney joshedney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gingerbenw gingerbenw merged commit 7b0820f into next Jan 17, 2025
134 checks passed
@gingerbenw gingerbenw deleted the gingerbenw/cocoapods-build-issue branch January 17, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshedney joshedney joshedney approved these changes

@yousif-bugsnag yousif-bugsnag Awaiting requested review from yousif-bugsnag

@lemnik lemnik Awaiting requested review from lemnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @joshedney