drop @bugsnag/core/(client|event|session) exports

[djskinner]

Drop these importing directly from source and use the compiled assets in @bugsnag/core

I first tried to split this by doing client only first but there were issue where the client was then referring to the compiled version of Event whilst other places referred to a different Event, that of the source code

[github-actions]

@bugsnag/browser bundle size diff

	Minified	Minfied + Gzipped
Before	77.20 kB	17.45 kB
After	51.47 kB	15.76 kB
±	-25,734 bytes	-1,691 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against dc7c41e

[djskinner]

as i mentioned in previous PR i think its right that core externalises all its dependencies leaving the individual notifiers to bundle what they need

[gingerbenw]

I may be misunderstanding the point of the external dependencies, but why do we need node_modules here?

[djskinner]

This statement makes rollup treat all node_modules as external - see https://stackoverflow.com/questions/44844088/how-to-set-as-external-all-node-modules-in-rollup

This means that instead of pulling a load of code into the core bundle they contine to be referenced externally:

const require$$0 = require('error-stack-parser');
const StackGenerator = require('stack-generator');
const require$$2 = require('@bugsnag/safe-json-stringify');
const require$$0$1 = require('iserror');
const cuid = require('@bugsnag/cuid');

// esm version
import require$$0 from 'error-stack-parser';
import StackGenerator from 'stack-generator';
import require$$2 from '@bugsnag/safe-json-stringify';
import require$$0$1 from 'iserror';
import cuid from '@bugsnag/cuid';

The thing is if core copied @bugsnag/cuid into its bundle then a number of other plugins also did this then there would be multiple copies of @bugsnag/cuid code and what's more different instances of it which may cause issues in some situations.

What I'm saying is that for all these shared libraries like core and plugins that are consumed by multiple notifiers they should externalise all their dependencies. Then its left to the notifier builds themselves to pull in a single copy of every external dependency (as you would always want for a browser build). You may or may not want this for a node notifier build, but this gives use the option.

[gingerbenw]

okay, understood! that definitely makes sense then. thanks! 👍🏻

[djskinner]

schema is now being exported from @bugsnag/core - these are the manually crafted types for that (for now) - copied from the internal typings against the js source

[djskinner]

also exporting schema now