Find and use Gazelle's repo config in bb fix
#8270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a mixed MODULE.bazel/WORKSPACE setup, `go_deps` has almost certainly been migrated, so prefer MODULE.bazel over WORKSPACE in that case to go through the Bzlmod path in `bb fix`.
|
@sluongng I wonder whether running a prebuilt gazelle is the best approach with Bzlmod. Setting up gazelle requires a single line in |
sluongng
approved these changes
Feb 14, 2025
sluongng
reviewed
Feb 14, 2025
| return "", fmt.Errorf("failed to find repo config file: %w", err) | ||
| } | ||
| if len(matches) == 0 { | ||
| return "", errors.New("failed to find repo config file, please run a build first") |
There was a problem hiding this comment.
it seems like we are failing at this step in CI.
Perhaps we can materialize the repo by running a quick bazel query?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a mixed MODULE.bazel/WORKSPACE setup,
go_depshas almost certainly been migrated, so prefer MODULE.bazel over WORKSPACE in that case to go through the Bzlmod path inbb fix.