remote_cache: Use upload compression on all code paths #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to (configurably) apply upload compression only to `UploadFile`, not e.g. `UploadBlob`. Fix this by moving the logic into the private function that lies on all code paths.
|
The test failure is legitimate, but I'm not sure whether it actually encodes the intended behavior. |
bduffany
reviewed
Feb 11, 2025
bduffany
reviewed
Feb 11, 2025
Comment on lines
+251
to
+253
| if *enableUploadCompression { | ||
| r.SetCompressor(repb.Compressor_ZSTD) | ||
| } |
There was a problem hiding this comment.
I think we should avoid mutating r here (if possible?) Ideally have the caller specify the compressor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to (configurably) apply upload compression only to
UploadFile, not e.g.UploadBlob. Fix this by moving the logic into the private function that lies on all code paths.