Add a test for qps.go #8391
Open
Add a test for qps.go #8391
+98
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
reviewed
Feb 12, 2025
Comment on lines
41
to
+47
| func NewCounter(window time.Duration) *Counter { | ||
| return new(window, nil) | ||
| } | ||
|
|
||
| func NewCounterForTesting(window time.Duration, ticker <-chan time.Time) *Counter { | ||
| return new(window, ticker) | ||
| } |
There was a problem hiding this comment.
nit: probably more conventional to have only a single constructor and have it accept an instance of clockwork.Clock rather than a ticker channel
| } | ||
| // The current bin is incremented asynchronously upon receiving a tick via | ||
| // the ticker channel. Give it some time to run. | ||
| time.Sleep(10 * time.Millisecond) |
There was a problem hiding this comment.
This will likely be flaky. Could do one of these instead
- Have the QPS counter accept an optional
updateschannel (chan struct{}) and send a non-blocking message on that channel whenever a tick is processed. Then the test can receive from the channel here instead of waiting for an update. - Do whitebox testing - move qps_test to the qps package, and manually call some
update(now time.Time)function in the QPS counter rather than driving the counter using a ticker. - Do a poll here and wait indefinitely for the condition to become true - probably the simplest option but the downside though is that the test will just reach the test timeout if there's a bug rather than immediately failing - a little annoying but probably fine.
|
|
||
| func TestQPS(t *testing.T) { | ||
| ticker := make(chan time.Time, 1) | ||
| counter := qps.NewCounterForTesting(5*time.Second, ticker) |
There was a problem hiding this comment.
probably want to defer counter.Stop() here
|
|
||
| func TestRaciness(t *testing.T) { | ||
| ticker := make(chan time.Time, 1) | ||
| counter := qps.NewCounterForTesting(5*time.Second, ticker) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use a similar time-binning ring buffer to track error rates for performing failover in a new gRPC client. This is the first step towards extracting the time-binning logic into a different place where it can be reused.