-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge devel into master branch #1816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
some of the keys that it can be declared are 'pbs', 'torque', 'lsf', 'slurm', 'cobalt' for specifying directory paths where to search for binaries.
…hich will be a list of colon separated list of directory paths where to search for binaries
binary paths as a dictionary. An optional argument custom_dirs can be used to search for binary in additional paths that will be appended to PATH
needed. We are doing this check later in SiteConfiguration class
method from the class Change Torque class to be subclass of Scheduler instead of PBS and make use of custom_dirs to properly detect the binary paths. We have changed logic on how to determine a scheduler is active
correct binary paths
correct binary paths
correct binary paths
in the if condition since we still want to poll them and they will be cancelled once maxpendtime is reached
For sleep_cancel job we will hold the job so it cancels
for more information, see https://pre-commit.ci
job also forgot to call method retrieve_jobdata in gather method for SlurmExecutor class which is needed to get the job data used for detecting the exitcode
remove unnecessary return statement that caused issue with cobalt job to not cancel job since return value was None
for more information, see https://pre-commit.ci
…nstall we needed to add option to wget --no-check-certificate to get the script to install. We updated the example buildspecs for pbs tests
change logic for when to retrieve get_queues method for PBS and Torque only if check method pass
…nfiguration Add support for 'paths' in configuration to allow one to search for scheduler binary in non-standard location
migrating From RefResolver to Referencing
suppress output of curl and installation of pip in setup.sh
…ass to match argument name and update all references in regression test
…l YAML files to refelect new name
…ssion test and instead use the configuration stored in $BUILDTEST_ROOT/buildtest/settings/spack_container.yml
…ctory Change option name to 'buildtest buildspec find --directory' for searching for root buildspecs when building cache
…o add into buildspec cache instead of just --directory option which will recursively add all files in a directory. The file must be valid and must exist on file system and end with .yml extension to be added into the cache
…load into buildspec cache
…ldspec_cache Add support for specifying a file path via -f/--file when loading buildspec into cache
add changelog for v2.1
bump version to 2.1
add release date for version 2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.