Merge --directory and --file for buildspec buildspec find to option --search #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to remove input arguments since we dont need them. We have renamed some variables and initial attempt at implementation of merging the directory and file option
…pports both file and directory.
and fix a typo in variable name when no buildspecs were found
update json schema update lookup key in implementation when searching for buildspecs
update configuration file with keyword 'search' for searching buildspecs since 'directory' is no longer supported
shahzebsiddiqui
deleted the
merge_directory_and_file_into_single_option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will merge implementation for directory and file based search for buildspecs into single option named
--searchthat will be used to search for buildspecs by file or directory.This would also change the configuration file name from
directorytosearch