-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch out spectral for vacuum #46
Open
philsturgeon
wants to merge
13
commits into
main
Choose a base branch
from
vacuum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
force-pushed
the
vacuum
branch
2 times, most recently
from
January 7, 2025 12:56
4a4c6ed
to
fbbc877
Compare
|
Hi @philsturgeon I discovered vacuum this morning. Seems awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ditching Spectral (especially via the not ideal Super-Linter) to go with the entirely open-source (and loads quicker) vacuum CLI.
Blog post on integration incoming! 🥳
The JUnit integration is not perfect, but @daveshanley has been improving it using this as a test case. As of v0.15.1 it now shows line numbers, but we need to get the files reporting in the results too. Whenever that happens I'll update it, but this is good enough for now because we only have one file:
openapi.yaml
.