Deprecate .theme() #4995
Open
Deprecate .theme() #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should now be able to pull the correct theme from the Context from the associated RequestManager, which makes this method largely not useful. The only exception would be an attempt to do a themed loading using the Application Context where a theme of some Fragment or Activity is available. I assume that case is relatively rare and it's probably better to just do the load with the Fragment or Activity Context anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should now be able to pull the correct theme from the Context from the associated RequestManager, which makes this method largely not useful.
The only exception would be an attempt to do a themed loading using the Application Context where a theme of some Fragment or Activity is available. I assume that case is relatively rare and it's probably better to just do the load with the Fragment or Activity Context anyway.