-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stop shuffling ranger_handles and incident_types
Currently those fields under an incident get randomly sorted in the API response, since a frozenset is unordered. This surfaces on the incidents page, where ranger handles and incident types both show up in a random order. That's kind of weird. This is a pretty simple fix for that, which makes the API response consistent. I've looked through the Git history a fair bit to see why frozensets were used in the first place. I'm fairly confident it was just because we needed an immutable, hashable collection with duplicates removed. This new way achieves those same ends too, but it also maintains ordering. https://github.com/search?q=repo%3Aburningmantech%2Franger-ims-server+frozenset&type=commits
- Loading branch information
Showing
3 changed files
with
11 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters