don't show location on incidents page if it'd be "(?:?@)" #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1362 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 181 181
Lines 8894 8894
Branches 1488 1488
=======================================
Hits 6153 6153
Misses 2641 2641
Partials 100 100 ☔ View full report in Codecov by Sentry. |
The Rod Garett-style addresses are often left empty in practice, since they're often not relevant (e.g. Gerlach, or Black Rock Station, or unknown). It's kind of an eyesore to see those displayed as "(?:?@)" in the incidents table.
srabraham
force-pushed
the
2024-11-04-location-formatting
branch
from
00d7fd9
to
9ffecce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rod Garett-style addresses are often left empty in practice, when they're irrelevant (e.g. Gerlach, or Black Rock Station, or unknown). It's kind of an eyesore to see those displayed as "(?:?@)" in the incidents table. Before and after example pics are below.