Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop shuffling ranger_handles and incident_types #1368

Closed
wants to merge 1 commit into from
Closed

stop shuffling ranger_handles and incident_types #1368

wants to merge 1 commit into from

Commits on Nov 5, 2024

  1. stop shuffling ranger_handles and incident_types 

    Currently those fields under an incident get randomly sorted in
the API response, since a frozenset is unordered. This surfaces on
the incidents page, where ranger handles and incident types both
show up in a random order. That's kind of weird.

This is a pretty simple fix for that, which makes the API response
consistent.

I've looked through the Git history a fair bit to see why frozensets
were used in the first place. I'm fairly confident it was just
because we needed an immutable, hashable collection with duplicates
removed. This new way achieves those same ends too, but it also
maintains ordering.
https://github.com/search?q=repo%3Aburningmantech%2Franger-ims-server+frozenset&type=commits
    @srabraham
    srabraham committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    81a4d35 View commit details
    Browse the repository at this point in the history