Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak login page's title and email label #1380

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

srabraham
Copy link
Member

I went with "email (or handle)" for a while, but I'm now thinking we should just stay simple and ask for email only.

The title of the page was a bit weird before, just saying "Log In". I think it's better to say the name of the system instead, but I could be convinced otherwise.

Before:
image

After:
image

Copy link
Contributor

github-actions bot commented Nov 7, 2024

⚠️ Optional matrix job Py:3.14.0-alpha.1 - ubuntu-latest failed ⚠️

  • tox prefix: test
  • exit status: 1

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.25%. Comparing base (aaab0ff) to head (369cd49).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/element/login/_login.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
+ Coverage   69.23%   69.25%   +0.02%     
==========================================
  Files         181      181              
  Lines        8916     8916              
  Branches     1490     1490              
==========================================
+ Hits         6173     6175       +2     
+ Misses       2643     2642       -1     
+ Partials      100       99       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeburg
Copy link

mikeburg commented Nov 7, 2024

+1 to only mentioning using an email address, and not handles. Each event, the Tech On Call team receives numerous support requests because people attempt to use their callsigns, only to discover that the callsign must be entered precisely, with exact capitalization and punctuation.

Obviously, such strict requirements are not playa brain friendly.

@srabraham
Copy link
Member Author

+1 to only mentioning using an email address, and not handles. Each event, the Tech On Call team receives numerous support requests because people attempt to use their callsigns, only to discover that the callsign must be entered precisely, with exact capitalization and punctuation.

Obviously, such strict requirements are not playa brain friendly.

Yuuuup, not even while on call, I coincidentally had to help multiple people with that same thing at BRC 2024

I went with "email (or handle)" for a while, but I'm now thinking
we should just stay simple and ask for email only.

The title of the page was a bit weird before, just saying "Log In".
I think it's better to say the name of the system instead, but I
could be convinced otherwise.
@srabraham srabraham enabled auto-merge (rebase) November 7, 2024 18:09
@srabraham srabraham merged commit b866d3a into master Nov 7, 2024
11 checks passed
@srabraham srabraham deleted the 2024-11-07-login-email branch November 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants