Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audit #51

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: audit #51

merged 2 commits into from
Jan 30, 2025

Conversation

Peartes
Copy link
Contributor

@Peartes Peartes commented Jan 27, 2025

This PR addresses two key issues identified during the contract audit:

Fix Secp256R1 Overriding Index Bypass:

  • Ensured that all authenticator additions, including Secp256R1, now utilize the save_authenticator function to prevent bypassing the OverridingIndex check.

Enhance EthWallet Address Validation:

  • Ensured that addresses start with 0x and have the correct length of 42 characters.
  • Normalized addresses to lowercase to prevent inconsistent tracking.

@ash-burnt ash-burnt marked this pull request as ready for review January 30, 2025 22:42
@ash-burnt ash-burnt merged commit a60d498 into main Jan 30, 2025
2 checks passed
@ash-burnt ash-burnt deleted the fix/audit branch January 30, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edjroz edjroz edjroz approved these changes

@ash-burnt ash-burnt ash-burnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Peartes @edjroz @ash-burnt