Expose ResolveAll in an external module #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some situations where it's preferable to have Murmur usable as a library, rather than as a separate executable.
In Issue 471 the use case is for testing, but I have an additional use case where I need to resolve secrets from a configuration file rather than environment variables.
Currently, that's not possible since Murmur doesn't expose any external interface at all. This PR adds a minimal external interface which wraps the internal function ResolveAll for external use. As a wrapper, this still allows the freedom to change or remove the internal ResolveAll function if required, it would just require additional changes in the wrapper to preserve the existing call signature.