Streamline Generate #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claytongentry
commented
Nov 21, 2024
johncarney
reviewed
Nov 21, 2024
johncarney
requested changes
Nov 21, 2024
johncarney
approved these changes
Nov 21, 2024
| @logger.error("Vector configuration not found: #{path}") | ||
| return nil | ||
| end | ||
| raise "Vector configuration not found: #{path}" unless path.file? |
There was a problem hiding this comment.
A non-existent or non-file file are not the only possible failure modes here. It could also be an invalid YAML file. Consider replacing this with rescues for Errno::ENOENT, Errno::EISDIR, and Psych::Exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
generateinterface to accept no arguments. You just callmanifold generateto generate the manifolds for all workspaces in your project.I also factored out the BigQuery service. I think we can consider BigQuery the only destination we're generating things for for the foreseeable future and skip managing the complexity of multiple targets for now.
Copied over the general generation logic from the former BigQuery service into a
#generatemethod on Workspaces, but oop'ified it.I also renamed the housing directory for workspaces, projects and vectors to
api, reflecting the module hierarchy.