Fix the fadvise handling of large offsets on FreeBSD.
#1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On FreeBSD, when a large `u64` converts to a negative offset, we add some special-case behavior to hide the fact that this conversion is happening. Clarify the comments, update the code to do a proper no-op in the case of a negative offset, and use the correct length in the case of an overflowing offset+length.
sunfishcode
force-pushed
the
sunfishcode/freebsd-fadvise
branch
from
bbb742a to
0fb7cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD, when a large
u64converts to a negative offset, we add some special-case behavior to hide the fact that this conversion is happening. Clarify the comments, update the code to do a proper no-op in the case of a negative offset, and use the correct length in the case of an overflowing offset+length.